Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change phrasing for 'Configure signing in gradle' on 'Build and release an Android app' page #5110

Closed
Bookie164 opened this issue Dec 19, 2020 · 1 comment · Fixed by #10388
Closed

Change phrasing for 'Configure signing in gradle' on 'Build and release an Android app' page #5110

Bookie164 opened this issue Dec 19, 2020 · 1 comment · Fixed by #10388
Assignees
@atsansone
Labels
dev.deployment Relates to deploying Flutter app section of Flutter.dev e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged target.Android Target apps on the Android Platform

Comments

@Bookie164
Copy link

Bookie164 commented Dec 19, 2020 •
edited by atsansone

Page URL: https://docs.flutter.dev/deployment/android#configure-signing-in-gradle
Page source: https://github.com/flutter/website/tree/master/src/docs/deployment/android.md

Description of issue:
This page used to show how to configure Gradle by showing two code blocks. One code block would replace another so the usage of replace "code1" with "code2" was ok. Like in the attached screenshot.
Screenshot 2020-12-19 at 12 02 32 PM

Now it tells you to add code instead of replace yet in the second code block it reads as if you are replacing the initial code. It's a minor change but replace...with makes sense add...with does not. Makes for better readability.
@sfshaza2 sfshaza2 added e1-hours Effort: < 8 hrs p2-medium Necessary but not urgent concern. Resolve when possible. labels Jan 8, 2021
@atsansone atsansone added target.Android Target apps on the Android Platform from.page-issue Reported in a reader-filed concern dev.deployment Relates to deploying Flutter app section of Flutter.dev labels May 17, 2023
@atsansone atsansone changed the title 'Build and release an Android app' page issue Change phrasing for 'Configure signing in gradle' on 'Build and release an Android app' page May 23, 2023
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label May 23, 2023
@atsansone atsansone self-assigned this Sep 3, 2023
@atsansone
Copy link
Contributor

Investigate at the same time as #5110.

@atsansone atsansone added e0-minutes Effort: < 60 min and removed e1-hours Effort: < 8 hrs labels Sep 30, 2023
@sfshaza2 sfshaza2 added e1-hours Effort: < 8 hrs and removed e0-minutes Effort: < 60 min labels Nov 2, 2023
@parlough parlough mentioned this issue Apr 8, 2024
Merged
atsansone added a commit that referenced this issue Apr 9, 2024
@atsansone
Fix gradle signing inconsistency (#10388)
819a0c0 
Fixes #5110
sfshaza2 pushed a commit that referenced this issue Apr 23, 2024
@atsansone @sfshaza2
Fix gradle signing inconsistency (#10388)
82faeae 
Fixes #5110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atsansone atsansone

Labels
dev.deployment Relates to deploying Flutter app section of Flutter.dev e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged target.Android Target apps on the Android Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix gradle signing inconsistency atsansone/website
3 participants
@atsansone @sfshaza2 @Bookie164