New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hello world example to match current behavior #678
Conversation
Update hello world example with required textDirection as in examples/hello_world/lib/main.dart
Update widgets-intro.md
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Signed the CLA on 10:30 PST 9/17/2017. |
CLAs look good, thanks! |
Can you add a space after the comma? |
The Travis failure is because we're requiring the use of dartfmt, but here dartfmt is making the code uglier by wrapping in a poor way. We should probably exclude this file from dartfmt verification. cc @sethladd |
Added space after comma per request and formatting guidelines.
Added the space. Thanks. |
or maybe we can tell dartfmt to accept longer lines? iirc @mit-mit solved our most recent issue with Travis in this repo, maybe he has a quick way to address this one too. :-) |
|
I have no particular opinion on how to solve this. I don't think dartfmt can handle this code in a good way. I'd be fine with excluding this file, changing the line width globally (assuming it doesn't make anything else worse), not using dartfmt at all, or any other similar solution. |
A longer-than-80-char line length means that code can wrap and look bad when displayed inside a web page. |
Or, add trailing commas to the snippet, reformat it with dartfmt |
I suggest we just add some trailing commas and auto-format, which would give us:
|
formatting lgtm |
Pushed that change to this PR |
Travis is happy now, merging. @mattrenquist thanks for contributing, and sorry for being so slow with this PR. |
No worries. Glad I could help out even a little. Thanks. |
The current hello world example does not run. Adding 'textDirection' to match the code in examples/hello_world/lib/main.dart fixes the bug and allows the code to run. The website documentation should be updated to match the current code.