Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up code excerpt updater #10383

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Apr 8, 2024

Slightly reduce runtime of code excerpt updater by doing less unneeded work :)

  • Only run on src/content directory. All code excerpt instructions are within that directory currently.
  • Don't add any of the global replacements, they currently are relied on by any of the excerpts on the site.

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit a6af01e):

https://flutter-docs-prod--pr10383-feat-speed-up-code-excerpt-3e95fmn9.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. woot!!

@sfshaza2 sfshaza2 merged commit 1d658a7 into main Apr 8, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the feat/speed-up-code-excerpt-updater branch April 8, 2024 05:35
atsansone pushed a commit to atsansone/website that referenced this pull request Apr 8, 2024
Slightly reduce runtime of code excerpt updater by doing less unneeded
work :)

- Only run on `src/content` directory. All code excerpt instructions are
within that directory currently.
- Don't add any of the global replacements, they currently are relied on
by any of the excerpts on the site.
sfshaza2 pushed a commit that referenced this pull request Apr 9, 2024
Slightly reduce runtime of code excerpt updater by doing less unneeded
work :)

- Only run on `src/content` directory. All code excerpt instructions are
within that directory currently.
- Don't add any of the global replacements, they currently are relied on
by any of the excerpts on the site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants