Adding plugin migration page. #3249
Conversation
googlebot
added
the
cla: yes
| libraries to ensure backwards compatibility. The `android.support` | ||
| libraries are deprecated, and replaced with | ||
| [AndroidX]({{site.android-dev}}/jetpack/androidx/). | ||
| Android code often uses the [`android.support`][] |
There was a problem hiding this comment.
There are a few instances of replacing links with [foo][]. Why is this preferable? It seems like it's easier to end up with broken links.
There was a problem hiding this comment.
It is our convention. The text is far more readable without the inline link. And Travis tells us of broken links.
There was a problem hiding this comment.
Is Travis a human or a bot? It would nice to have the validation automated since it's almost impossible to review visually.
There was a problem hiding this comment.
Travis is a CI tool. We used to use it on flutter/flutter, but now it's Cirrus. Very much a bot. :) . We also run a weekly linkcheck over the site.
There was a problem hiding this comment.
Okay, phew. I didn't want a real Travis to be hurt about me not knowing if they were a bot or not. I think bot Travis will get over it.
| @@ -4,18 +4,17 @@ description: How to fix AndroidX incompatibilities that have been detected by th | |||
| --- | |||
|
|
|||
| {{site.alert.note}} | |||
| You might be directed to this page if the framework detects a problem in your | |||
There was a problem hiding this comment.
I thought I left some comments here yesterday but I can't find it anymore. It might not have gone through.
I unfortunately have to revert the non-add-to-app changes in this add-to-app branch. Keeping 2 branches is difficult but feasible for purely additive changes. But for changes on existing files like this, it's hard to merge since the base text already changed on master (specifically for this file, it already moved on master). I tried to manually downport some of the non-add-to-app changes back to master but since the base text was so different, I think it's going to be easier to just re-create these changes directly on an up-to-date master.
TL;DR the new plugin-api-migration.md and sidenav.yml will be mergeable to master but the rest will be difficult.
For some reason, I am unable to stage this branch. The tool/serve.sh script doesn't work.
Please review, or delegate to the correct person. Thx!