Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an add-to-app landing page #3265

Merged
merged 4 commits into from Nov 20, 2019
Merged

Add an add-to-app landing page #3265

merged 4 commits into from Nov 20, 2019

Conversation

xster
Copy link
Member

@xster xster commented Nov 19, 2019

No description provided.

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Nov 19, 2019
@xster xster requested a review from blasten November 19, 2019 04:00
sfshaza2
sfshaza2 approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see some minor stuff I'd like to fix, but that can be done in a later PR. LGTM

src/_data/sidenav.yml Outdated
@@ -145,6 +145,8 @@
- title: Add Flutter to existing app
permalink: /docs/development/add-to-app
children:
- title: Introduction
permalink: /docs/development/add-to-app/index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have to specify index. Just /docs/development/add-to-app should be sufficient.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sg, thanks!

blasten
blasten approved these changes Nov 20, 2019
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xster xster merged commit eec9d12 into flutter:staging-add-to-app-do-not-delete-until-2020 Nov 20, 2019
@xster xster deleted the landing-page branch November 20, 2019 02:15
xster added a commit that referenced this pull request Nov 22, 2019
@xster
Add an add-to-app landing page (#3265)
57d41c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blasten blasten blasten approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@zoeyfan zoeyfan Awaiting requested review from zoeyfan

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xster @blasten @sfshaza2 @googlebot