Convert add-to-app Android screen and fragment pages to use tabs for languages. #3336
Conversation
googlebot
added
the
cla: yes
| setupTabs($('#no-engine-vc-language'), 'io.flutter.tool-id'); | ||
| setupTabs($('#entrypoint-library-language'), 'io.flutter.tool-id'); | ||
| setupTabs($('#initial-route-language'), 'io.flutter.tool-id'); | ||
| setupTabs($('.nav-tabs'), 'io.flutter.tool-id'); |
There was a problem hiding this comment.
rather than repurposing one of these existing bootstrap classes, let's just make a new one so we can make sure everything's clean and we don't affect other things
There was a problem hiding this comment.
Seems like you changed the various tabs themselves to have sample-code-tabs but didn't change the scan here. Can you also change the iOS page's tabs as well to use the new class?
There was a problem hiding this comment.
Here is a PR that introduces a new Liquid tag and adds that selector change that I missed:
#3350
| @@ -255,6 +291,20 @@ Please see the [instructions for instantiating and starting a `FlutterEngine`]. | |||
| To use a pre-warmed `FlutterEngine` in a `FlutterFragment`, instantiate a | |||
There was a problem hiding this comment.
line 289 doesn't work. I don't think such link exists.
There was a problem hiding this comment.
It looks like this branch has
docs/development/add-to-app/android/add-splash-screen
which may be relevant.
There was a problem hiding this comment.
I removed the link for now.
| <div class="tab-content"> | ||
|
|
||
| <div class="tab-pane active" id="use-prewarmed-engine-java-tab" role="tabpanel" aria-labelledby="use-prewarmed-engine-java-tab" markdown="1"> | ||
| <?code-excerpt "MyApplication.java" title?> | ||
| ```java | ||
| // Somewhere in your app before your FlutterFragment is needed... |
There was a problem hiding this comment.
since you called the thing MyApplication.java, you might as well reference it in this sentence.
|
Otherwise content LG |
matthew-carroll
merged commit 0d3fc03
into
flutter:staging-add-to-app-do-not-delete-until-2020
Convert add-to-app Android screen and fragment pages to use tabs for languages.