Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reword add-to-app landing page and add video #3338

Conversation

xster
Copy link
Member

@xster xster commented Dec 4, 2019

No description provided.

@xster xster requested review from blasten and zoeyfan December 4, 2019 06:25
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Dec 4, 2019
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm /w nits

- Build your Flutter module into a generic [Android AAR](https://developer.android.com/studio/projects/android-library)
- Android Studio Android/Flutter co-editing and module creation/import wizard
- Java and Kotlin host apps supported
- Build your Flutter module into a generic [Android AAR](https://developer.android.com/studio/projects/android-library).
Copy link

@blasten blasten Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Android Archive (AAR)

- Flutter modules can use [Flutter plugins](https://pub.dev/flutter) to interact
with the platform. Android plugins should be [migrated to the V2 plugins APIs](/docs/development/packages-and-plugins/plugin-api-migration)
for best add-to-app correctness.
- Support for Flutter debugging and Stateful Hot Reload by using `flutter attach`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: does this need to be capitalized?

with the platform. Android plugins should be [migrated to the V2 plugins APIs](/docs/development/packages-and-plugins/plugin-api-migration)
for best add-to-app correctness.
- Support for Flutter debugging and Stateful Hot Reload by using `flutter attach`
from IDEs or the command line to connect to an app containing Flutter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: period

IDEs or the command line to connect to an app containing Flutter
with the platform.
- Support for Flutter debugging and Stateful Hot Reload by using `flutter attach`
from IDEs or the command line to connect to an app containing Flutter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto: missing period

@xster
Copy link
Member Author

xster commented Dec 5, 2019

Done, thanks.

@xster xster merged commit 32b728b into flutter:staging-add-to-app-do-not-delete-until-2020 Dec 5, 2019
@xster xster deleted the tweak-landing-page branch December 5, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants