-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce add-to-app iOS setup image size, other cleanup #3345
Reduce add-to-app iOS setup image size, other cleanup #3345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter_application_path = '../my_flutter' | ||
load File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb') | ||
``` | ||
<?code-excerpt "MyApp/Podfile" title?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually fix the ordered list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding 4 characters does it, right @sfshaza2? https://stackoverflow.com/a/18089124/431116
See the <?code-excerpt "{codelabs/startup_namer/step1_base,layout/base}/lib/main.dart"?>
line in
https://raw.githubusercontent.com/flutter/website/e6368d3e3bd0098b9727afff43501ddc6248d571/src/docs/development/ui/layout/tutorial.md
@@ -174,10 +174,7 @@ into your targets's build settings > General > Frameworks, Libraries, and Embedd | |||
<div class="row"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also just replace this whole thing with a {% include app-figure.md... if you want
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though Travis will let us know for sure.
Fix up URLs with incorrect anchors, reduce size of png by resizing and using optipng.