Reduce add-to-app iOS setup image size, other cleanup #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
xster
reviewed
Dec 5, 2019
| flutter_application_path = '../my_flutter' | ||
| load File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb') | ||
| ``` | ||
| <?code-excerpt "MyApp/Podfile" title?> |
There was a problem hiding this comment.
Does this actually fix the ordered list?
There was a problem hiding this comment.
I think adding 4 characters does it, right @sfshaza2? https://stackoverflow.com/a/18089124/431116
See the <?code-excerpt "{codelabs/startup_namer/step1_base,layout/base}/lib/main.dart"?> line in
https://raw.githubusercontent.com/flutter/website/e6368d3e3bd0098b9727afff43501ddc6248d571/src/docs/development/ui/layout/tutorial.md
| @@ -174,10 +174,7 @@ into your targets's build settings > General > Frameworks, Libraries, and Embedd | |||
| <div class="row"> | |||
There was a problem hiding this comment.
you can also just replace this whole thing with a {% include app-figure.md... if you want
|
LGTM |
sfshaza2
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up URLs with incorrect anchors, reduce size of png by resizing and using optipng.