-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify initial route usage with cached engines. #3551
Clarify initial route usage with cached engines. #3551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, though I am wondering why you've added what appears to be identical text/code to two different files. Are there differences I am missing with my visual scan? I know one file addresses Flutter fragments and the other addresses Flutter screens, but the sections seem to be the same.
Otherwise, LGTM
@sfshaza2 the question of using an initial route with a cached engine applies to both Also, it looks like we now have some kind of enforced review process. Can you explicitly add your approval via the GitHub button so that I'll be allowed to merge? |
@RedBrogdon I added you as a reviewer to this in case you have a moment to press the GitHub approve button. I'm currently blocked from merging until someone does that... |
@matthew-carroll feel free to reach out to me as well if the situation arises again, happy to help out. |
src/docs/development/add-to-app/android/add-flutter-fragment.md
Outdated
Show resolved
Hide resolved
src/docs/development/add-to-app/android/add-flutter-fragment.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Jon Tippens <legalcodes@users.noreply.github.com>
Co-Authored-By: Jon Tippens <legalcodes@users.noreply.github.com>
Changing the initial route property of the navigation channel after the initial | ||
execution of `runApp()` has no effect. Developers who would like to use | ||
the same `FlutterEngine` between different `Activity`s and `Fragment`s and | ||
switch the route between those displays need to setup a method channel and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
switch the route between those displays need to setup a method channel and | |
switch the route between those displays need to set up a method channel and |
Thanks @legalcodes. I'm gonna add you to another website PR. |
Sure, np |
Also, if this has urgency no need to worry about the nits. We can track them and make the updates at a later time. |
@matthew-carroll, @legalcodes, I wouldn't have approved this PR. Rather than adding identical text to two pages, I would have refactored it by creating a _foo.md file and including it into both places. Otherwise it's difficult to maintain. You can see this sort of thing done in the /src/docs/get-started/install directory. |
Clarify initial route usage with cached engines.