Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAQ re "ubershaders" #5162

Merged
merged 2 commits into from Jan 7, 2021
Merged

FAQ re "ubershaders" #5162

merged 2 commits into from Jan 7, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Jan 7, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Jan 7, 2021
@sfshaza2 @filiph
Update src/docs/perf/rendering/shader.md
12bf3a4 
Co-authored-by: Filip Hracek <filiph@users.noreply.github.com>
sfshaza2
sfshaza2 approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Thanks for catching that URL nit, @filiph.)

@sfshaza2 sfshaza2 merged commit 3cd8d4f into master Jan 7, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Jan 8, 2021

Thanks!

@sfshaza2 sfshaza2 deleted the Hixie-patch-1 branch January 20, 2021 20:59
filiph added a commit to filiph/website that referenced this pull request Feb 22, 2021
@Hixie @sfshaza2 @filiph
FAQ re "ubershaders" (flutter#5162)
99dc015 
* FAQ re "ubershaders"

* Update src/docs/perf/rendering/shader.md

Co-authored-by: Filip Hracek <filiph@users.noreply.github.com>

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Filip Hracek <filiph@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiph filiph filiph left review comments

@sfshaza2 sfshaza2 sfshaza2 approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hixie @filiph @sfshaza2