Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shader mask for web on shimmer loading cookbok notice #6009

Merged
merged 1 commit into from Jul 14, 2021
Merged

Remove shader mask for web on shimmer loading cookbok notice #6009

merged 1 commit into from Jul 14, 2021

Conversation

daniel-naegele
Copy link
Contributor

As the ShaderMask should work again (flutter/flutter#44152), the notice that it would not work from the shimmer loading cookbok was removed

As the ShaderMask should work again (flutter/flutter#44152), the notice that it would not work was removed
@google-cla
Copy link

google-cla bot commented Jul 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Contributor has not signed the Contributor License Agreement label Jul 9, 2021
@daniel-naegele
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Jul 9, 2021
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2
Copy link
Contributor

The build breakage is not related to this PR. Forcing a merge.

@sfshaza2 sfshaza2 merged commit 2155d8d into flutter:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants