Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ebook #6019

Merged
merged 6 commits into from Jul 12, 2021
Merged

Add new ebook #6019

merged 6 commits into from Jul 12, 2021

Conversation

TahaTesser
Copy link
Member

This adds a very handy ebook for Flutter libraries

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Jul 11, 2021
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple changes and I can land. Thx!

@@ -76,3 +76,10 @@
cover: programming-flutter.jpg
link: "https://pragprog.com/book/czflutr"
desc: "Native, Cross-Platform Apps the Easy Way. Doesn't require previous Dart knowledge."
- title: 'Flutter Libraries we love'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These books are organized alphabetically by title. Please move this up in the list.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, true.

publisher: Codemagic
cover: flutter_libraries_we_love.png
link: "https://codemagic.io/flutter-libraries-ebook/"
desc: "\"Flutter libraries we love\" focuses on 11 different Flutter library categories. Each category has a list of Flutter libraries as well as a highlighted library that we dig deeper into – including pros and cons, developer's perspective and real-life code examples. The code snippets of all 11 highlighted libraries are updated to their latest versions, which support Flutter 2 with sound null safety."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid writing in first person "we dig..." and remember the Oxford comma. :D I removed "latest versions" because that can go out of date fast.

Suggested change
desc: "\"Flutter libraries we love\" focuses on 11 different Flutter library categories. Each category has a list of Flutter libraries as well as a highlighted library that we dig deeper into – including pros and cons, developer's perspective and real-life code examples. The code snippets of all 11 highlighted libraries are updated to their latest versions, which support Flutter 2 with sound null safety."
desc: "\"Flutter libraries we love\" focuses on 11 different categories of Flutter libraries. Each category lists available libraries as well as a highlighted library that is covered in more detail – including pros and cons, developer's perspective, and real-life code examples. The code snippets of all 11 highlighted libraries support Flutter 2 with sound null safety."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the review, changes are made :)

@TahaTesser TahaTesser requested a review from sfshaza2 July 12, 2021 20:15
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 merged commit ffd896f into flutter:master Jul 12, 2021
@TahaTesser TahaTesser deleted the new_book branch July 12, 2021 22:21
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eng-Mouaz-M-AlShahmeh
Copy link

Eng-Mouaz-M-AlShahmeh commented Jun 4, 2023

Flutter Apps Development
by Mouaz M. Al-Shahmeh
Build Cross-Platform Flutter Apps with Trust (First Edition - June - 2023) (Flutter 3.10 - Dart 3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants