Add enhance tracing and shader compilation docs to DevTools #6866
Conversation
johnpryan
requested review from
sfshaza2,
khanhnwin and
domesticmouse
as code owners
| app. Frames that are performing shader compilation are marked in dark | ||
| red: | ||
|
|
||
|  |
There was a problem hiding this comment.
I would use a different screenshot that shows a janky frame with shader compilation time. A warning icon will show up if the frame is actually janky. Also could be good to show the tooltip when you hover over the janky frame, which will show how much time on the raster thread was spent compiling shaders.
There was a problem hiding this comment.
I'm not sure why, but in looking at the staged version, this image isn't displayed.
There was a problem hiding this comment.
@kenzieschmoll SGTM
@sfshaza2 When I stage the site it tries to load the image from docs.flutter.dev, and it doesn't exist yet. I think I can edit _config.yml to change site.url to point to my staging site, though.
There was a problem hiding this comment.
Ah, I hadn't run into this yet. Don't worry about it!
| app. Frames that are performing shader compilation are marked in dark | ||
| red: | ||
|
|
||
|  |
There was a problem hiding this comment.
I'm not sure why, but in looking at the staged version, this image isn't displayed.
|
cc: @InMatrix |
| app. Frames that are performing shader compilation are marked in dark | ||
| red: | ||
|
|
||
|  |
There was a problem hiding this comment.
Ah, I hadn't run into this yet. Don't worry about it!
…6866) * Add docs for enhance tracing and shader compilation in DevTools * Address code review comments
Adds enhance tracing and shader compilation docs to the DevTools performance page.
fixes #6749
fixes #6752
@kenzieschmoll
staged:
https://flutter-website-jr-stagi-988d4.web.app/development/tools/devtools/performance
Presubmit checklist