Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI plugin docs #7111

Merged
merged 5 commits into from
May 11, 2022
Merged

FFI plugin docs #7111

merged 5 commits into from
May 11, 2022

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented May 11, 2022

Fixes #7073

parlough
parlough reviewed May 11, 2022
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I just have some minor comments/questions.

Also do we have a FFI plugin sample we could point to?

src/development/packages-and-plugins/developing-packages.md Outdated Show resolved Hide resolved
src/development/packages-and-plugins/developing-packages.md Outdated Show resolved Hide resolved
src/development/packages-and-plugins/developing-packages.md Outdated Show resolved Hide resolved
src/development/packages-and-plugins/developing-packages.md Outdated Show resolved Hide resolved
src/development/packages-and-plugins/developing-packages.md Outdated Show resolved Hide resolved
src/development/packages-and-plugins/developing-packages.md Outdated Show resolved Hide resolved
@mit-mit @parlough
Apply suggestions from code review
2f2b92f 
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@mit-mit
Copy link
Member Author

mit-mit commented May 11, 2022

Also do we have a FFI plugin sample we could point to?

I'm afraid not currently.

parlough
parlough approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks good to me :)

You may have to reopen/update the PR once @khanhnwin incorporates the WIP website changes.

src/development/packages-and-plugins/developing-packages.md Outdated Show resolved Hide resolved
@mit-mit @parlough
Update src/development/packages-and-plugins/developing-packages.md
f00d021 
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@khanhnwin
Copy link
Contributor

Fix for stable build is part of #7113 . Once that's merged in, we can merge from main into this branch and it should pass the build.

@mit-mit
Copy link
Member Author

mit-mit commented May 11, 2022

@khanhnwin can you help ensuring this gets merged when ready? It's nearly midnight here, so I'm heading out shortly...

@khanhnwin
Copy link
Contributor

@mit-mit Will do!

@khanhnwin khanhnwin merged commit 6a4d437 into flutter:main May 11, 2022
@khanhnwin
Copy link
Contributor

Merged! Thanks @mit-mit!

@mit-mit mit-mit deleted the pluginffi branch May 11, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@johnpryan johnpryan johnpryan approved these changes

@khanhnwin khanhnwin khanhnwin approved these changes

@parlough parlough parlough approved these changes

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2 sfshaza2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs for FFI plugins
5 participants
@mit-mit @khanhnwin @domesticmouse @johnpryan @parlough