Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding info on iOS app extensions #8265

Merged
merged 19 commits into from
Mar 20, 2023
Merged

Adding info on iOS app extensions #8265

merged 19 commits into from
Mar 20, 2023

Conversation

leighajarett
Copy link
Contributor

Description of what this PR is changing or adding, and why:

This adds a new page that describes how Flutter developers can add iOS app extensions. This is a popular feature request: flutter/flutter#16092. It also adds a few plugins to the existing page that talks about Apple system libraries.

I am submitting this now to get the review started, but we shouldn't publish it until we have published the two codelabs (I am currently working on them and hoping to have a draft ready in the next few weeks) and this PR is merged: flutter/plugins#7114

I couldn't figure out how to get the images to be a bit smaller, or how to fix the numbered list with an image -- if anyone knows how to fix this that would be amazing!

Issues fixed by this PR (if any): #7448

Presubmit checklist

@domesticmouse
Copy link
Contributor

the two codelabs (I am currently working on them and hoping to have a draft ready in the next few weeks)

Hey Leigha, can you add me to the codelab docs? Also, I'm curious if you plan to add the code for said codelabs to https://github.com/flutter/codelabs?

FYI @sfshaza2

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few requested edits.

src/_data/sidenav.yml Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
@leighajarett
Copy link
Contributor Author

FYI @atsansone and @sfshaza2 -- I made a few updates based on the feedback and a conversation I had with @jmagman yesterday. Feel free to take another look and let me know if you want further changes.

Instead of creating two codelabs, only one will be referenced in this doc. The other, I just put the steps directly in the doc since this isn't a fully supported workflow. Also, I needed to change the images to HTML to get the correct sizing indentation. Feel free to propose an alternative.

@atsansone if you update anything can you leave it as a suggestion so I can make sure that it's all good from a technical perspective? I noticed you added the commit directly to this branch in the last iteration. Thank you!! :)

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leighajarett : Some comments should be addressed (issue), even if it's just to say Acknowledged. The others are up to you.

Thanks!

src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
src/development/platform-integration/ios/app-extensions.md Outdated Show resolved Hide resolved
@atsansone atsansone added the review.await-update Awaiting Updates after Edits label Feb 17, 2023
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
@leighajarett
Copy link
Contributor Author

@atsansone and @jmagman I've gone through all your comments and made adjustments. Feel free to take another look!

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @sfshaza2 and @atsansone are happy. Thanks again for doing this!

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @leighajarett !

@atsansone atsansone added st.RFM Ready to merge or land and removed review.await-update Awaiting Updates after Edits labels Mar 8, 2023
@sfshaza2
Copy link
Contributor

sfshaza2 commented Mar 14, 2023

@leighajarett, we can't merge this PR until it passes all tests. The linkcheck is failing because the page includes this link: [Adding Home Screen Widgets to your Flutter](http://codelabs.developers.google.com/flutter). The correct link is https://codelabs.developers.google.com/?product=flutter. Can you fix?

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out a not-yet-available codelab, fixed a malformed link, indented a note. With these fixes, the CI should build and this can be merged.

@kaciula
Copy link

kaciula commented Apr 19, 2023

@leighajarett Where can I find the iOS app extension codelab? Or where can I follow its development? I can't currently find it in the available Flutter codelabs.

@sfshaza2 sfshaza2 removed the st.RFM Ready to merge or land label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants