Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Take picture with Camera in list image picker #39

Closed
nhtlquan opened this issue Jul 3, 2020 · 11 comments
Closed

[Feature] Take picture with Camera in list image picker #39

nhtlquan opened this issue Jul 3, 2020 · 11 comments
Labels
r: photo_manager Related to the photo_manager package. s: feature There's a feature request in this issue. s: UI This issue is related with UI or layout.

Comments

@nhtlquan
Copy link

nhtlquan commented Jul 3, 2020

Version information (版本信息)

  • Device: e.g. iPhone6
  • OS: e.g. iOS 13.4
  • Package Version: e.g. v2.1.0
  • Flutter Version: e.g. v1.17.1

Is your feature request related to a problem? (功能是否与已有问题关联)
Capture camera.

Describe the solution you'd like (描述你期望的解决方案)
Capture camera when picker multi image, insert one more button on index 0 of list image picker!

Describe alternatives you've considered (其他解决方案或疑虑)
A clear and concise description of any alternative solutions or features you've considered.

Additional context (附加内容)
Add any other context or screenshots about the feature request here.

@nhtlquan nhtlquan added await investigate The issue is waiting for further investigation. s: feature There's a feature request in this issue. labels Jul 3, 2020
@github-actions github-actions bot added the await triage The issue is waiting for triage. label Jul 3, 2020
@AlexV525
Copy link
Member

AlexV525 commented Jul 4, 2020

Is it okay if you put an option before pick assets to let users choose to take camera or pick assets?

@nhtlquan
Copy link
Author

nhtlquan commented Jul 6, 2020

Is it okay if you put an option before pick assets to let users choose to take camera or pick assets?

I know, but Design and BA need take picture from gridview Image! Please help me.
I have tried adding an item camera in the gridview . But when I took a picture and reloaded the image from getAssetsFromEntity. But it takes about 10 seconds for new images to appear. :(

@AlexV525
Copy link
Member

AlexV525 commented Jul 6, 2020

But when I took a picture and reloaded the image from getAssetsFromEntity. But it takes about 10 seconds for new images to appear. :(

Have you tried to add AssetEntity through photo manager? Ref: https://github.com/CaiJingLong/flutter_photo_manager#insert-new-item

Provide the ability to customize the first or the last item is better than provide a camera shooting as I thought. But still, it needs some time to investigate and implement.

@AlexV525 AlexV525 added e: goal This issue is a goal for development. r: photo_manager Related to the photo_manager package. s: UI This issue is related with UI or layout. and removed await triage The issue is waiting for triage. labels Jul 6, 2020
@nhtlquan
Copy link
Author

nhtlquan commented Jul 6, 2020

`

void takeCamera() async {
final file = await ImagePicker.pickImage(source: ImageSource.camera)
if (file == null) {
return;
}
final Uint8List byteData = await file.readAsBytes(); // Convert to Uint8List
final AssetEntity imageEntity = await PhotoManager.editor.saveImage(byteData);
provider.addAssetCamera(imageEntity);
_isLoadingSubject.sink.add(true);
}
`
I tried, but not work. On pixel 3 XL, android 10.

@AlexV525
Copy link
Member

AlexV525 commented Jul 6, 2020

I tried, but not work. On pixel 3 XL, android 10.

Which part didn't worked? Returned null? Or a error thrown?

/cc @CaiJingLong

@nhtlquan
Copy link
Author

nhtlquan commented Jul 6, 2020

I tried, but not work. On pixel 3 XL, android 10.

Which part didn't worked? Returned null? Or a error thrown?

/cc @CaiJingLong

Take 1 picture with camera and PhotoManager.editor.saveImage => open grid image with flutter_wechat_assets_picker ==>
photo just taken not appear
==> need wait 10 second or take one more picture with camera ==> item will be appear

@nhtlquan
Copy link
Author

nhtlquan commented Jul 6, 2020

Sorry bro, I made a mistake.

@nhtlquan
Copy link
Author

nhtlquan commented Jul 7, 2020

Hi bro, Please update new feature: Take picture with camera in grid view list image!

@AlexV525
Copy link
Member

AlexV525 commented Jul 8, 2020

Is there any problem currently when you're trying to integrate with photo_manager ?

@AlexV525 AlexV525 added e: documentation Improvements or additions to documentation. release candidate and removed await investigate The issue is waiting for further investigation. labels Jul 9, 2020
AlexV525 added a commit that referenced this issue Jul 9, 2020
@AlexV525
Copy link
Member

AlexV525 commented Jul 9, 2020

Try 3.0.0-dev.1 .

@AlexV525 AlexV525 added await response Issue require customer's further response. and removed e: documentation Improvements or additions to documentation. e: goal This issue is a goal for development. await response Issue require customer's further response. labels Jul 9, 2020
@AlexV525
Copy link
Member

Published in 3.0.0 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r: photo_manager Related to the photo_manager package. s: feature There's a feature request in this issue. s: UI This issue is related with UI or layout.
Projects
None yet
Development

No branches or pull requests

2 participants