Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Padding issue in MultiTabs delegate example on iOS #395

Closed
LeGoffMael opened this issue Dec 14, 2022 · 1 comment
Closed

[BUG] Padding issue in MultiTabs delegate example on iOS #395

LeGoffMael opened this issue Dec 14, 2022 · 1 comment
Labels
await investigate The issue is waiting for further investigation. e: PR welcomed Can be improved by PRs. s: enhancement New feature or request. s: UI This issue is related with UI or layout.

Comments

@LeGoffMael
Copy link
Collaborator

LeGoffMael commented Dec 14, 2022

Describe the bug
There is an unnecessary padding at the top of the grid view in the MultiTabAssetPickerBuilder example on iOS.

How to reproduce
Run the MultiTabAssetPickerBuilder example on an iPhone.

Expected behavior
The grid view and the path list dropdown widget should be stick to the top of the view.

It seems that it comes from kToolbarHeight at line 1197 and 1593 of DefaultAssetPickerBuilderDelegate.

Remove it fix the issue for MultiTabAssetPickerBuilder but the problem of padding appear on the commun pickers when shouldRevertGrid: false.

i could fixed it with an ugly fix, but it is definitely not ideal.

MediaQuery(
  data: MediaQuery.of(context).copyWith(
    padding: const EdgeInsets.only(top: -kToolbarHeight),
  ),
  child: Builder(
    builder: (BuildContext context) => Stack(
      children: <Widget>[
        RepaintBoundary(
          child: Column(
            children: <Widget>[
              Expanded(child: assetsGridBuilder(context)),
              if (isPreviewEnabled) bottomActionBar(context),
            ],
          ),
        ),
        pathEntityListBackdrop(context),
        pathEntityListWidget(context),
      ],
    ),
  ),
)

Screenshots (If contains)
the blue arrow shows the top padding

grid view albums list

Version information

  • Device: iPhone 11 pro
  • OS: 16.1.1
  • Package Version: master branch, 8.2.0
  • Flutter Version: 3.3.9
@LeGoffMael LeGoffMael added the await investigate The issue is waiting for further investigation. label Dec 14, 2022
@github-actions github-actions bot added the await triage The issue is waiting for triage. label Dec 14, 2022
@AlexV525
Copy link
Member

This is likely caused by extra calculations when reverting the asset grid. I didn't pay too much caution when writing the multi-tab example.

@AlexV525 AlexV525 added s: enhancement New feature or request. s: UI This issue is related with UI or layout. e: PR welcomed Can be improved by PRs. and removed await triage The issue is waiting for triage. labels Dec 23, 2022
AlexV525 added a commit that referenced this issue Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
await investigate The issue is waiting for further investigation. e: PR welcomed Can be improved by PRs. s: enhancement New feature or request. s: UI This issue is related with UI or layout.
Projects
None yet
Development

No branches or pull requests

2 participants