Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup should include country code in the base lookup URL #17

Closed
shinsenter opened this issue Feb 18, 2020 · 3 comments
Closed

Lookup should include country code in the base lookup URL #17

shinsenter opened this issue Feb 18, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@shinsenter
Copy link
Contributor

Thank you for great package!

I'm trying to lookup my appId from getiOSAppID method, and it calls to: http://itunes.apple.com/lookup?bundleId=my.app.id.here

But the response always return
{
"resultCount":0,
"results": []
}

My app is ONLY available in Japan store, so the lookup should include country code in the base lookup URL:

http://itunes.apple.com/jp/lookup?bundleId=my.app.id.here

It would be great if I could add country code in to lookup URL, or change the base lookup URL.

@rodydavis rodydavis self-assigned this May 26, 2020
@rodydavis rodydavis added the enhancement New feature or request label May 26, 2020
@rodydavis
Copy link
Member

I am open for PRs this would be a great addition! Let me know and i will publish an update.

@shinsenter
Copy link
Contributor Author

@rodydavis
This may be resolved with #38.

rodydavis added a commit that referenced this issue Aug 7, 2020
@rodydavis
Copy link
Member

Fixed on 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants