Only reinitialize if ChewieController changed

fluttercommunity · Jan 23, 2019 · fc1bc16 · fc1bc16
1 parent 2bd06b7
commit fc1bc16
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/src/cupertino_controls.dart b/lib/src/cupertino_controls.dart
@@ -72,11 +72,14 @@ class _CupertinoControlsState extends State<CupertinoControls> {
 
   @override
   void didChangeDependencies() {
+    final _oldController = chewieController;
     chewieController = ChewieController.of(context);
     controller = chewieController.videoPlayerController;
 
-    _dispose();
-    _initialize();
+    if (_oldController != chewieController) {
+      _dispose();
+      _initialize();
+    }
 
     super.didChangeDependencies();
   }

diff --git a/lib/src/material_controls.dart b/lib/src/material_controls.dart
@@ -65,11 +65,14 @@ class _MaterialControlsState extends State<MaterialControls> {
 
   @override
   void didChangeDependencies() {
+    final _oldController = chewieController;
     chewieController = ChewieController.of(context);
     controller = chewieController.videoPlayerController;
 
-    _dispose();
-    _initialize();
+    if (_oldController != chewieController) {
+      _dispose();
+      _initialize();
+    }
 
     super.didChangeDependencies();
   }