Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragable progressbar #712

Merged
merged 7 commits into from May 12, 2023
Merged

Conversation

shiyiya
Copy link
Contributor

@shiyiya shiyiya commented Feb 23, 2023

lib/src/progress_bar.dart Outdated Show resolved Hide resolved
lib/src/progress_bar.dart Outdated Show resolved Hide resolved
@diegotori
Copy link
Collaborator

Please format your dart code so that it adheres to standard Dart formatting as per flutter format.

lib/src/progress_bar.dart Outdated Show resolved Hide resolved
lib/src/progress_bar.dart Outdated Show resolved Hide resolved
@shiyiya shiyiya requested a review from diegotori March 1, 2023 04:27
@knyghtryda
Copy link

@diegotori curious when this will be merged into a release. We are running into this issue in production. Thanks!

@diegotori
Copy link
Collaborator

@shiyiya LGTM. Just have to smoke test them on my end later this week.

@knyghtryda
Copy link

Any chance this can be merged at this point?

@diegotori
Copy link
Collaborator

@shiyiya Smoke test successful. Will merge this very shortly.

@diegotori diegotori merged commit a4815a2 into fluttercommunity:master May 12, 2023
diegotori added a commit that referenced this pull request May 12, 2023
lg8294 added a commit to lg8294/chewie that referenced this pull request May 12, 2023
* master:
  Version 1.5.0. Addresses PR fluttercommunity#712.
  Upgraded iOS Example App's Xcode files.
  Added latest dart format changes.
  Fixed app.dart lint issues.
  Added CI fixes due to Dart 3.
  Version 1.4.1. Addresses PR fluttercommunity#719.
  Fix overlay not visible
  Update progress_bar.dart
  again
  fix(ci): deprecated command
  again
  Update progress_bar.dart
  Update progress_bar.dart
  Update chewie_player.dart

# Conflicts:
#	example/ios/Runner.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants