fix display size while Chewie wrapped by some rotate widget #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Will try out your changes either tonight or tomorrow night. |
|
@bailyzheng sorry for the delay. Will get a chance to run it on my end first thing tomorrow. |
diegotori
added a commit
that referenced
this pull request
Nov 28, 2023
lg8294
added a commit
to lg8294/chewie
that referenced
this pull request
Dec 6, 2023
* master: chewie, version 1.7.4. Addresses fluttercommunity#757. chewie, version 1.7.3. Addresses fluttercommunity#777. Added comments and optimised code fix display size while Chewie wrapped by some rotate widget Lint issue Fixed Revert "Update cupertino_controls.dart" Update cupertino_controls.dart Fixed : Playback speed reset on forwarding video # Conflicts: # lib/src/player_with_controls.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Chewie wrapped by RotatedBox like this. It is used in the situation that device not support landscape and portrait switch.
It will not occupy all the space.
Use LayoutBuilder instead of MediaQuery is more adaptive. It looks like this now.
