Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify when URL changes #13

Closed
gurmukhp opened this issue Sep 4, 2017 · 9 comments
Closed

Notify when URL changes #13

gurmukhp opened this issue Sep 4, 2017 · 9 comments

Comments

@gurmukhp
Copy link

gurmukhp commented Sep 4, 2017

Would it be possible to add a feature to know when the URL of the browser has changed?

Currently using Oauth2, if a http server is the redirect, some apps show a warning to the user that the credentials are being sent to an insecure server.

If https is used, then iOS throws an error loading the redirect url.

@lejard-h
Copy link
Collaborator

lejard-h commented Sep 5, 2017

it should be easy to do on Android, but no idea on iOS, @toufikzitouni an idea ?

@toufikzitouni
Copy link

@lejard-h not on the top of my head. Do you have an Android implementation? I can work off of it and mimic the logic on iOS

@lejard-h
Copy link
Collaborator

I will implement it this week end, but basically I plan to use builtin methods form the Android Webview and send the url to a Dart Stream.

@toufikzitouni
Copy link

@lejard-h sounds good! I can work off of your implementation once done for iOS

@marwan-at-work
Copy link

any luck with the ios implementation?

@pedia
Copy link
Contributor

pedia commented Dec 9, 2017

#18 This coming in pull request.

@marwan-at-work
Copy link

@pedia that’s great! Hope it gets merged soon

@lejard-h
Copy link
Collaborator

will be fix in the next release, after #21 get fixed @pedia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants