-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make WebViewStateChanged's navigationType nullable #907
base: master
Are you sure you want to change the base?
Make WebViewStateChanged's navigationType nullable #907
Conversation
Please, take a look @charafau |
It is happening on iPhone also. Web view state is not changing (keeps on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helpful one and thanks for the help @micaelcid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolves #910 about the onStateChanged stream is not working
@mainteiner |
Hello guys, could you please merge this PR 🙏 ? |
@charafau @slightfoot @lejard-h can you guys please take a look? |
@ramah @jonasfranz @themisir could you please take a look? |
@augustorsouza I don't have write permissions to the repository. I would suggest using dependency from git source until the changes are released. |
@micaelcid thank you so much. I spent lots of time fixing problem, and finally, find your PR. |
@augustorsouza Hello. |
Hey, @charafau. Could you please review, merge and get this PR in the next release? It seems that plenty of people wants this fix too 😢 |
does anyone have forks with this fix and migrated to V2 embedding? |
I was able to make this work by overriding the dependency and using this fork created by @micaelcid Just add it on your pubspec.yaml
Thanks @micaelcid! I hope this PR will be accepted soon! |
Hey folks, just letting you know: We're not using this fork anymore, although I'll leave this PR opened as a reference, in case anyone still needs it. We fully migrated to https://pub.dev/packages/webview_flutter after they added file upload feature to the Android platform. |
Description
After updating our app to use the latest null-safety release, we realized the
onStateChanged
stream stopped working in our Android devices and emulators.After a few hours of debugging with @wescosta, we realized
navigationType
wasn't defined in theMap<String, dynamic>
- so making it nullable resolved the issue.Now all our WebViews are back and working like they used to.