Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improves disposal function used in resetLazySingleton and unregister #185

Merged
merged 1 commit into from
May 6, 2021
Merged

improves disposal function used in resetLazySingleton and unregister #185

merged 1 commit into from
May 6, 2021

Conversation

kmartins
Copy link
Contributor

@kmartins kmartins commented May 5, 2021

Uses await only if the disposal function is a future in resetLazySingleton and unregister.

@kmartins kmartins changed the base branch from incoming to null_safety May 5, 2021 20:18
@kmartins kmartins mentioned this pull request May 5, 2021
Closed
@escamoteur escamoteur merged commit 6b327bf into fluttercommunity:null_safety May 6, 2021
@escamoteur
Copy link
Collaborator

This test

test('reset lazy Singleton when the disposing function is not a future',)

Failed because you forget to pass a dispose function that calls the constructor

@kmartins
Copy link
Contributor Author

kmartins commented May 6, 2021

OK, thanks for correcting this and merging the PR 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmartins @escamoteur