Fix wrong type checking when using instanceName in combination with generic type parameter #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this code snippet fails:
with the message:
The reason for this is, that the logic for checking the type or the object registered with instanceName is wrong:
registeredObject.registrationType
is of TypeType
andT
is of TypeString
(in this case), so the comparison fails.This only works if the caller does not use generic type parameters, because then
T
is of typedynamic
, anddynamic
is a bottom type, so theX is dynamic
is always true.This PR fixes this by checking the type of the actual instance.
I also added a test for this.