-
-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question]: Why was kotlin_version bumped in latest version of device_info_plus, package_info_plus? #2245
Comments
I also wanted to note that while connectivity_plus also states this as a breaking change, I was able to successfully compile an app with connectivity_plus and kotlin 1.7.10. It doesn't seem like connectivity_plus has a kt version in the build.gradle file as the plugin is written in java. |
I'm getting since the last update the following error message error: cannot find symbol
flutterEngine.getPlugins().add(new dev.fluttercommunity.plus.packageinfo.PackageInfoPlugin()); |
It is a matter of preference. PRs with Kotlin bump were already merged. I didn't want to roll them back, so introduced a breaking change release as knew about problems that Kotlin 1.8.x introduces for projects with both new and old Kotlin versions available
Yes, it is good idea, but it is up to maintainers of packages to decide which versions to use. In this case we had latest Kotlin version already merged and I am as a maintainer of Plus Pluginsis totally Ok with that as believe that projects should stick to modern versions. But for future releases I asked other active maintainers to not merge these Android related Dependabot PRs that fast to not need to introduce breaking changes again, especially since Kotlin releases 1.8.x brought issues to users with dependencies with older Kotlin versions.
Good catch. Our mistake during changelog generation. |
There is no further space for discussion as I am not looking for advises on releases strategy for Plus Plugins, so closing this one as answered. |
Open another issue and provide all the required info as your comment isn't related to the question. |
Is there an issue or discussion board about the release strategy? |
There is already an answer provided above. No, there is no discussion or issue and no plans for it. |
Update: Latest breaking changes will be retracted for every plugin except |
What is your question?
Hey folks - I was hoping to get some context as to why kotlin_version was bumped in the latest version of a few packages (in particular device_info_plus and package_info_plus). I tried to get some context from the PRs to bump the version. There was some discussion about it here: #2134
Is there an issue this resolves, or a feature that required this?
Flutter projects created with the latest stable/beta versions default to kotlin 1.7.10. I would think it would make sense to stick with that version of kotlin unless there was a good reason to force a higher version on consumers.
Checklist before submitting a question
flutter pub upgrade
flutter clean
The text was updated successfully, but these errors were encountered: