Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase device_info_plus version to ^10.0.0 #3932

Closed
3 of 14 tasks
quoc-huynh-cosee opened this issue Oct 10, 2023 · 4 comments
Closed
3 of 14 tasks

Increase device_info_plus version to ^10.0.0 #3932

quoc-huynh-cosee opened this issue Oct 10, 2023 · 4 comments
Labels
Build Issues related to building apps using Amplify flutter feature-request A request for a new feature or an enhancement to an existing API or category.

Comments

@quoc-huynh-cosee
Copy link

quoc-huynh-cosee commented Oct 10, 2023

Description

I'm currently using amplify_auth_cognito: ^1.4.2 and tried to update device_info_plus to the new version ^10.0.0, but I receive the following error:

Because no versions of amplify_auth_cognito match >1.4.2 <2.0.0 and amplify_auth_cognito 1.4.2 depends on amplify_analytics_pinpoint >=1.4.1 <1.5.0, amplify_auth_cognito ^1.4.2 requires amplify_analytics_pinpoint >=1.4.1 <1.5.0.
Because amplify_analytics_pinpoint 1.4.1 depends on device_info_plus ^9.0.0 and no versions of amplify_analytics_pinpoint match >1.4.1 <1.5.0, amplify_analytics_pinpoint >=1.4.1 <1.5.0 requires device_info_plus ^9.0.0.
Thus, amplify_auth_cognito ^1.4.2 requires device_info_plus ^9.0.0.
So, because myapp depends on both amplify_auth_cognito ^1.4.2 and device_info_plus ^10.0.0, version solving failed.

Categories

  • Analytics
  • API (REST)
  • API (GraphQL)
  • Auth
  • Authenticator
  • DataStore
  • Notifications (Push)
  • Storage

Steps to Reproduce

  1. Create a new project
  2. Add amplify_auth_cognito: ^1.4.2 to pubspec.yaml
  3. Add device_info_plus: ^10.0.0 to pubsec.yaml
  4. Run flutter pub get

Screenshots

No response

Platforms

  • iOS
  • Android
  • Web
  • macOS
  • Windows
  • Linux

Flutter Version

3.13.6

Amplify Flutter Version

1.4.1

Deployment Method

Amplify CLI

Schema

No response

@Jordan-Nelson Jordan-Nelson added the pending-triage This issue is in the backlog of issues to triage label Oct 10, 2023
@Jordan-Nelson
Copy link
Member

Hello @quoc-huynh-cosee - Thanks for opening the issue. The latest version contains a breaking change. I have opened an issue in fluttercommunity/plus_plugins (fluttercommunity/plus_plugins#2245) to get more context on this breaking change before we make any changes.

In the mean time, I believe you could use a dependency override if desired. Keep in mind that we have not run our test suite against the latest version of this plugin so you will want to ensure the app is working as expected.

@Jordan-Nelson Jordan-Nelson added Investigating pending-external-action Build Issues related to building apps using Amplify flutter and removed pending-triage This issue is in the backlog of issues to triage labels Oct 10, 2023
@Jordan-Nelson
Copy link
Member

For the time being, we are going to leave the version constrain as is. Updating the constraint to ^5.0.0 would result in a breaking change, which we try to avoid when possible. Updating the constraint to a range (">=4.0.0 <6.0.0") would lead to a less than ideal experience as those that do not want to upgrade kotlin would be forced to pin the version of package_info_plus.

We are going to investigate how we can allow the use the latest version of this plugin without a breaking change and/or a less than ideal experience. I will comment here when we have an update. In the meantime, please let us know if the dependency override does not work for you.

@Jordan-Nelson Jordan-Nelson added feature-request A request for a new feature or an enhancement to an existing API or category. and removed Investigating pending-external-action labels Oct 11, 2023
@vbuberen
Copy link

Update from Plus Plugins side - I will retract latest breaking changes version for all plugins, except connectivity_plus where min iOS bump is still a reason for releasing breaking change, so there will be no need to come up with additional strategies. The reason of retraction - fluttercommunity/plus_plugins#2251

@Jordan-Nelson
Copy link
Member

Closing for now as version 10 was retracted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issues related to building apps using Amplify flutter feature-request A request for a new feature or an enhancement to an existing API or category.
Projects
None yet
Development

No branches or pull requests

3 participants