Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The wifi name is missing double quotes #986

Closed
KamiWen opened this issue Jul 29, 2022 · 5 comments
Closed

[Bug]: The wifi name is missing double quotes #986

KamiWen opened this issue Jul 29, 2022 · 5 comments
Labels
android bug Something isn't working network_info_plus

Comments

@KamiWen
Copy link

KamiWen commented Jul 29, 2022

Platform

Android 7

Plugin

network_info_plus

Version

2.1.3

Flutter SDK

3.0.5

Steps to reproduce

  1. Setup a wifi router with the name [得瑟@#_&-+()/%¥$^={}\*"':;!
  2. Call NetworkInfo().getWifiName() to get the wifi name.
  3. And then get the name is [得瑟@#_&-+()/%¥$^={}\*':;!
  4. It missing the "

Code Sample

No response

Logs

no log

Flutter Doctor

[√] Flutter (Channel stable, 3.0.5, on Microsoft Windows [版本 10.0.19043.1826], locale zh-CN)
    • Flutter version 3.0.5 at D:\Android\flutter\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (2 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2
    • Pub download mirror https://pub.flutter-io.cn        
    • Flutter download mirror https://storage.flutter-io.cn

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at d:\Android\SDK\
    • Platform android-32, build-tools 31.0.0
    • Java binary at: D:\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)    
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe     

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2020.3)
    • Android Studio at D:\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code (version 1.69.2)
    • VS Code at C:\Users\kami1\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.44.0

[√] Connected device (4 available)
    • Redmi Note 4X (mobile) • c7026a1c0104 • android-arm64  • Android 7.0 (API 24)
    • Windows (desktop)      • windows      • windows-x64    • Microsoft Windows [版本 10.0.19043.1826]
    • Chrome (web)           • chrome       • web-javascript • Google Chrome 103.0.5060.134
    • Edge (web)             • edge         • web-javascript • Microsoft Edge 103.0.1264.71

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.
@KamiWen KamiWen added bug Something isn't working triage labels Jul 29, 2022
@miquelbeltran
Copy link
Member

Interesting one. Is it only happening on Android, or are other platforms also affected?

@aakash-pamnani
Copy link
Contributor

This is due to line no 30 in this File .
There must be some reason to add this replace.

@miquelbeltran
Copy link
Member

Yeah, looks like this was done because Android added double quotes around the SSID name.

I would rather not remove the double quotes and let the developer using the plugin to handle that how they prefer.

Seems like an easy fix, do you want to submit a PR? Mention me once you submit it and I will review it quickly.

@aakash-pamnani
Copy link
Contributor

#1004 please review the PR

@miquelbeltran
Copy link
Member

this should be solved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working network_info_plus
Projects
None yet
Development

No branches or pull requests

3 participants