Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(network_info_plus): fixed a bug! #1004

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix(network_info_plus): fixed a bug! #1004

merged 2 commits into from
Aug 9, 2022

Conversation

aakash-pamnani
Copy link
Contributor

@aakash-pamnani aakash-pamnani commented Aug 8, 2022 •
edited
Loading

Description

Fixed a bug of wifi name not getting with double quotes #986

Related Issues

#968

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@aakash-pamnani
Copy link
Contributor Author

@miquelbeltran please review

@aakash-pamnani aakash-pamnani mentioned this pull request Aug 9, 2022
Closed
@miquelbeltran
Copy link
Member

Thanks @aakash-pamnani ! I will change the CHANGELOG a bit and then release the fix

@miquelbeltran miquelbeltran merged commit 2fc4646 into fluttercommunity:main Aug 9, 2022
Chever-John pushed a commit to Chever-John/plus_plugins that referenced this pull request Aug 30, 2022
@aakash-pamnani @Chever-John
fix(network_info_plus): fixed a bug! (fluttercommunity#1004)
4845e7d 
* Fixed wifi name not returning with "(double quote)

* updated changelog.md version

Co-authored-by: Aakas-h <76067278+Aakas-h@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miquelbeltran miquelbeltran miquelbeltran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aakash-pamnani @miquelbeltran