Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(all): Migrate to Melos 3 #1619

Merged
merged 5 commits into from Mar 15, 2023
Merged

Conversation

spydon
Copy link
Contributor

@spydon spydon commented Mar 13, 2023

Description

This migrates the repository and pipeline over to Melos 3.
The contributing guide doesn't have to be updated since that already installs the latest Melos version.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files. (Well, I did add the root pubspec file)
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@spydon
Copy link
Contributor Author

spydon commented Mar 13, 2023

@vbuberen I saw that you pinned the Melos version to 2.9.0 previously, I'm guessing it was just because you didn't have time to do the migration directly, or was there any other reason?

@vbuberen
Copy link
Collaborator

The reason was to not bump min Dart version to 2.18 as it is needed for Melos 3.0.0: https://github.com/invertase/melos/blob/main/CHANGELOG.md#melos---v300
Explained it in this PR: #1615

@spydon spydon mentioned this pull request Mar 14, 2023
7 tasks
@vbuberen
Copy link
Collaborator

Replied in #1615 that I missed the fact about separate pubspec.yaml for workspace. Looks good to me then.
Thanks for taking care of it. I would bump min Dart for that workspace pubspec, considering that it doesn't affect packages/users.

pubspec.yaml Outdated Show resolved Hide resolved
@vbuberen
Copy link
Collaborator

I tested this PR a bit earlier today and everything works fine.
We still have the issue with publishing: invertase/melos#467 but it is not Melos, but pub as it seems to me.

@vbuberen vbuberen merged commit 3bb18f2 into fluttercommunity:main Mar 15, 2023
6 checks passed
@spydon
Copy link
Contributor Author

spydon commented Mar 15, 2023

I tested this PR a bit earlier today and everything works fine. We still have the issue with publishing: invertase/melos#467 but it is not Melos, but pub as it seems to me.

Was it the examples' pubspec_overrides that were breaking it? If so I think I fixed it here:
#1628 :)

@vbuberen
Copy link
Collaborator

Was it the examples' pubspec_overrides that were breaking it? If so I think I fixed it here:
#1628 :)

No, it is not. Replied in that other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants