Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(package_info_plus): run integration tests #1687

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

blaugold
Copy link
Contributor

@blaugold blaugold commented Apr 14, 2023

Description

Move disabled web specific unit tests to integration tests and start running them together with existing integration tests. This is easier than using flutter test --platform chrome. --platform does not seem to be official supported anyway.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

e.g.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@blaugold
Copy link
Contributor Author

@vbuberen Hey :) Not sure who to ping to get a review on this PR. The motivation for this change is to be able to add the tests that were requested for #1330.

@vbuberen
Copy link
Collaborator

You are just in time with your ping as I am doing some changes to do another release in nearest days.

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@vbuberen vbuberen merged commit 7ba127f into fluttercommunity:main Apr 24, 2023
@blaugold blaugold deleted the package_info_plus-e2e-tests branch April 24, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants