Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connectivity_plus): update and fixe bugs for connectivity_plus #271

Merged
merged 5 commits into from Jun 7, 2021

Conversation

mhadaily
Copy link
Member

@mhadaily mhadaily commented Jun 3, 2021

Description

I tried to update our connectivity plugins to match the latest changes in Android and iOS and fix some bugs for the web.

Related Issues

This PR will address

#62
#260
#198
#98

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily
Copy link
Member Author

mhadaily commented Jun 3, 2021

I don't see any formatting issue
✅ All files are formatted correctly.

probably we should merge this PR first #272

@ueman
Copy link
Contributor

ueman commented Jun 4, 2021

I don't see any formatting issue
✅ All files are formatted correctly.

probably we should merge this PR first #272

flutter format had a small change in how it formats source code. It seems like the failure is exactly that case.

To reproduce it you can try running flutter format with 2.0.0 vs 2.2.0

@mhadaily
Copy link
Member Author

mhadaily commented Jun 4, 2021

I don't see any formatting issue
✅ All files are formatted correctly.
probably we should merge this PR first #272

flutter format had a small change in how it formats source code. It seems like the failure is exactly that case.

To reproduce it you can try running flutter format with 2.0.0 vs 2.2.0

Thank for the heads-up,

@mhadaily mhadaily closed this Jun 4, 2021
@mhadaily mhadaily reopened this Jun 4, 2021
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mhadaily mhadaily merged commit 34f6961 into main Jun 7, 2021
@mhadaily mhadaily deleted the majid/connectivity-update branch June 7, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants