build(android_alarm_manager_plus): Update to target and compile SDK 34 on Android #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
commented
Mar 16, 2024
| @@ -35,6 +35,10 @@ android { | |||
| targetCompatibility JavaVersion.VERSION_17 | |||
| } | |||
|
|
|||
| kotlinOptions { | |||
| jvmTarget = 17 | |||
There was a problem hiding this comment.
Had to do, so Android Studio doesn't pick 21 which is not supported yet but used Kotlin versions.
In fact, moving to Java 17 is something I want to do to the rest of plugins to be up to date. But such change will happen in another set of PRs.
|
One more thing I would like to address in follow-up PRs is to update the documentation and README with Android 14 related behavior changes information |
miquelbeltran
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving the plugin to target and compile against SDK 34 (Android 14).
Decided to also rework the example app a bit to let users request SCHEDULE_EXACT_ALARM permission. When app has no such permission schedule alarm button is disabled and request permission buttons is enabled. When user provides the permission schedule button becomes enabled while request permission button disables.
Additionally improved texts to improve UX by explaining what is currently happening.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).