3.0.0: Dart 2 Support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpryan
reviewed
Mar 29, 2018
ios/Flutter/Generated.xcconfig
Outdated
| FLUTTER_BUILD_MODE=debug | ||
| FLUTTER_BUILD_DIR=build | ||
| SYMROOT=${SOURCE_ROOT}/../build/ios | ||
| FLUTTER_FRAMEWORK_DIR=/Users/phillywiggins/lab/flutter/bin/cache/artifacts/engine/ios |
There was a problem hiding this comment.
not sure why flutter generates these guys, let's leave them out
There was a problem hiding this comment.
Ack, good call. Will do.
| @@ -7,4 +7,3 @@ with_content_shell: false | |||
| dart_task: | |||
| - test: --platform vm | |||
| - dartanalyzer: --fatal-warnings lib | |||
| - dartfmt | |||
There was a problem hiding this comment.
I've noticed that the Dart 1 and Dart 2 formatters format slightly differently. Is that why this was taken out?
There was a problem hiding this comment.
Yep, no way I could satisfy both for the time being. Would like to add it back in eventually.
|
Appreciate the review! I'll remove those extra files and publish a new version tomorrow morning :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having some type issues with Dart 2, and I found that we needed to change the implementation of Redux a bit. Overall, I actually think there might be an underlying bug with Dart 2, but this change simplifies the way our typed combinations work and provides good support for Dart 2.
Fixes #22
Changes:
ReducerBinding, useTypedReducercombineTypedReducer. UsecombineReducerswith normal reducers &TypedReducers.MiddlewareBinding, useTypedMiddleware.combineTypedMiddleware-- no longer needed! Just create a normalList<Middleware<State>>!