feat(wifi_iot): get info about AP configured for android>=30 [#134] #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallot
reviewed
Jan 5, 2022
daadu
requested changes
Jan 6, 2022
| @@ -379,12 +361,33 @@ class WiFiForIoTPlugin { | |||
| return sResult; | |||
| } | |||
|
|
|||
| static Future<String?> getHostpotSSID() async { | |||
There was a problem hiding this comment.
Can we not implement it with the existing getWiFiAPSSID API.
| return sResult; | ||
| } | ||
|
|
||
| static Future<String?> getHostpotPassword() async { |
There was a problem hiding this comment.
Should be renamed to getWiFiAPPassword - in line with other AP related APIs.
There was a problem hiding this comment.
Sorry we already have getWiFiAPPreSharedKey, can we use the same API instead.
daadu
changed the title
|
@percymudzinga Thank you for working on it. Also, sorry for late review. Related issue for this PR is #134, encourage you to go through it and implement other methods also if possible. |
daadu
changed the title
|
Closing this in favour of - #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.