fix: multiple triggering issue of NetworkCallback on Android 10 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weitsai
changed the title
|
+1 for the PR. The project is a bit outdated - needs a bit of cleanup - will merge this on coming weekend. |
Thank you for your assistance, and I appreciate you creating this toolkit. |
|
The fix has landed on pub.dev with Thanks for contributing, check yourself in CONTRIBUTORS.md file! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android 10, there is an issue where connection failures lead to repeated attempts to reconnect, resulting in the NetworkCallback being continuously triggered. However, within the context of Flutter, the FlutterResult allows only one return. To address this problem, it is recommended to unregister the NetworkCallback upon the first occurrence of the onUnavailable or onLost event, preventing subsequent redundant invocations. This pull request aims to implement this solution.