Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated heart loader for devs page #346

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

mgcarpizo
Copy link
Contributor

Closes #345

Zacharias02 and others added 30 commits February 14, 2021 16:13
…om jobs page

Fix dev page bug where the page is stuck in loading when switching from jobs page
…JackofAllTradesDev

docs: add JackofAllTradesDev as a contributor
…OliverRhyme

docs: add OliverRhyme as a contributor
…Zacharias02

docs: add Zacharias02 as a contributor
@joshuadeguzman
Copy link
Member

Hi @mgcarpizo! Thank you for this! :) Congrats for the shoutout.

Would it be possible if we rebase this to the latest master? I also recommend not including changes that are unrelated to this pull request 😄

Right now, there are about 75K+ line of changes 😅

30DaysOfFlutter 💙 automation moved this from In Progress to Reviewer Approved Feb 24, 2021
Copy link
Contributor

@vinceramcesoliveros vinceramcesoliveros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR!

…o 345/mgcarpizo

# Conflicts:
#	lib/features/dashboard/dashboard_page.dart
#	lib/features/devboard/devboard_page.dart
#	lib/features/devboard/devs/devs_list.dart
#	lib/loader.dart
#	pubspec.lock
#	pubspec.yaml
@mgcarpizo
Copy link
Contributor Author

@joshuadeguzman Hi! I've rebased and merged the changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
30DaysOfFlutter 💙
Reviewer Approved
Development

Successfully merging this pull request may close these issues.

[feat] Add heart loader for page loads
7 participants