Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/custom ide #176

Merged
merged 8 commits into from Feb 16, 2022
Merged

Feature/custom ide #176

merged 8 commits into from Feb 16, 2022

Conversation

aguilaair
Copy link
Member

2022-01-31.22-35-35.mp4.mp4

Closes #171

@aguilaair aguilaair added the enhancement New feature or request label Jan 31, 2022
@aguilaair aguilaair self-assigned this Jan 31, 2022
leoafarias
leoafarias requested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the custom IDE feature does not work on the mac when testing against Android Studio.

@aguilaair
Copy link
Member Author

aguilaair commented Feb 3, 2022 •
edited

@leoafarias what does it do?

Edit: tested AS on WIndows, works fine

Edit2: Target the following file /Applications/Android\ Studio.app/Contents/MacOS/studio

@aguilaair
Copy link
Member Author

@devj3ns what platform are you using (MacOS, Linux, or Windows)?

@devj3ns
Copy link

devj3ns commented Feb 4, 2022

@devj3ns what platform are you using (MacOS, Linux, or Windows)?

I am using windows

@aguilaair
Copy link
Member Author

I am using windows

Ok, it was just to see if you could try it if you had MacOS 😄

@aguilaair
Copy link
Member Author

2022-02-08.15-30-28.mp4.mp4

In this perfectly legal video you can see it works fine when using the studio executable, @leoafarias.

@leoafarias
Copy link
Member

@leoafarias what does it do?

Edit: tested AS on WIndows, works fine

Edit2: Target the following file /Applications/Android\ Studio.app/Contents/MacOS/studio

Adjusting this path does work

@aguilaair
Copy link
Member Author

Ok, so is it ready to merge?

@leoafarias leoafarias merged commit e34370f into main Feb 16, 2022
@leoafarias leoafarias deleted the feature/custom-ide branch February 16, 2022 19:27
@aguilaair aguilaair mentioned this pull request May 25, 2022
Closed
@rahat14
Copy link

rahat14 commented Jul 1, 2022

Not Wrking on Macbook M1

@aguilaair
Copy link
Member Author

Please open a new issue @rahat14 and provide some more details :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias Awaiting requested review from leoafarias

Assignees

@aguilaair aguilaair

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open project with IntelliJ and Android Studio
4 participants
@aguilaair @devj3ns @leoafarias @rahat14