Responsive Builder #19
Conversation
| import 'package:flutter/material.dart'; | ||
|
|
||
| class ResponsiveHelper { | ||
| static const double tabletMinWidth = 800; |
There was a problem hiding this comment.
Where did you get this code? From Android, I remember this value was 720.
| MediaQuery.of(context).size.width < desktopMinWidth; | ||
|
|
||
| static bool isDesktop(BuildContext context) => | ||
| MediaQuery.of(context).size.width >= desktopMinWidth; |
There was a problem hiding this comment.
I am not sure what this does. How can a width be related to desktop?
There was a problem hiding this comment.
It checks the screen width of the device. If the width is good for our desktop width, it returns true.
lib/widgets/responsive_builder.dart
Outdated
| @required this.mobile, | ||
| this.tablet, | ||
| @required this.desktop, | ||
| }) : assert(mobile != null, "Mobile cannot be empty."), |
There was a problem hiding this comment.
Let's use single quotes for texts.
lib/widgets/responsive_builder.dart
Outdated
| final Widget tablet; | ||
|
|
||
| /// 1200px | ||
| final Widget desktop; |
There was a problem hiding this comment.
Why we have a difference between desktop and tablets. An ipad can be as big as a laptop for example.
There was a problem hiding this comment.
I tried to use the standards like Bootstrap, Microsoft. Generally, sources use three different devices. Example
There was a problem hiding this comment.
Yes but that is not what we do with Flutter. We care about only the size. So let's try to keep it as small medium large etc.
There was a problem hiding this comment.
What is your suggestion? Should we remove the helper?
There was a problem hiding this comment.
We should rename them to something more generic. Because a desktop can be as small as a tablet and a tablet can be as big as a Desktop
There was a problem hiding this comment.
We can change the names to Small, Medium, Large.
Screen Names were updated.
Fixes #18