Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is debugMode? #312

Closed
ArturAralin opened this issue Jan 31, 2019 · 9 comments
Closed

Where is debugMode? #312

ArturAralin opened this issue Jan 31, 2019 · 9 comments
Assignees

Comments

@ArturAralin
Copy link

I feel self a bit stupid. Where is .debugMode(Boolean)? Maybe it was missed in the build?

My fluture version: 10.3.1

@Avaq
Copy link
Member

Avaq commented Jan 31, 2019

Hi @ArturAralin

Don't worry about it, there has been confusion about this before.

The problem is likely that you're using the modular Fluture build (using import Future). This build doesn't expose all functions on the Future constructor, but uses named exports instead. This is not very apparent from the README, and I should do something about that. It doesn't make it easier that the default export (Future), does have some functions; They are there to be compliant with Static Land.

To solve your problem, you could do import {debugMode} from 'fluture', or anything equivalent.

@ArturAralin
Copy link
Author

Absent of this function in index.ts.d may confuse other developers (like a me). I think need to add this function to index.ts.d

export function debugMode(debug: boolean): void;

What do you think about @Avaq?

@Avaq
Copy link
Member

Avaq commented Jan 31, 2019

Oh. You're absolutely right!

@ArturAralin
Copy link
Author

If it need I can open PR

@Avaq
Copy link
Member

Avaq commented Jan 31, 2019

I'll do it - there are other things missing from index.d.ts as well.

@Avaq Avaq self-assigned this Jan 31, 2019
Avaq added a commit that referenced this issue Jan 31, 2019
@ArturAralin
Copy link
Author

Ok. Thanks for the respond

@Avaq
Copy link
Member

Avaq commented Feb 4, 2019

It's merged to master, but I don't feel comfortable releasing it as a non-breaking change, as it potentially adds new constraints for TypeScript users, it's quite likely to break someones build.
I'm going to release it in the next major version, along with other breaking changes.

@ArturAralin
Copy link
Author

That's sad =(
But thanks for fix anyway

@Avaq
Copy link
Member

Avaq commented Feb 4, 2019

That's sad =(

I'm sorry. It shouldn't be long before the next release, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants