Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider TypeScript? #32

Closed
mr-mig opened this issue Sep 26, 2016 · 10 comments
Closed

Consider TypeScript? #32

mr-mig opened this issue Sep 26, 2016 · 10 comments

Comments

@mr-mig
Copy link

mr-mig commented Sep 26, 2016

IMO, TypeScript may be useful for a library like that.

@Avaq
Copy link
Member

Avaq commented Oct 4, 2016

Could you elaborate? Are you suggesting adding TypeScript type-definitions?

@mr-mig
Copy link
Author

mr-mig commented Oct 5, 2016

Yes, I propose to add definitions at least for the public API, although writing the library in TS may be helpful as well

@damncabbage
Copy link

damncabbage commented Oct 17, 2016

Interface definitions for both TypeScript and Flow would be useful, possibly via each's respective type-definition repositories (typings and flow-typed). I'd be worried about a full conversion to either without consideration whether the to-ES5 build process for one would make it harder to add annotations for the other.

I'll see what I can do about having a crack at the Flow side of this. Thanks again for writing this library. 😊

@Avaq
Copy link
Member

Avaq commented Oct 17, 2016

Awesome, @damncabbage! Please take note of #34; it changes a lot and might even make it easier to create type definitions because of much more explicit sub-classing.

@Avaq
Copy link
Member

Avaq commented Mar 14, 2017

Closing due to inactivity. I have no plans to work on this, and the issue does not seem to get a lot of attention. Feel free to reopen if you are still working on this, @damncabbage.

@Avaq Avaq closed this as completed Mar 14, 2017
@stevenyap
Copy link

In case other users who have found this thread via search engine, I have added the flow types for Fluture v6 in flow-typed flow-typed/flow-typed/pull/912

It is near completeness but works for all of my use cases for now.

@Avaq
Copy link
Member

Avaq commented Jun 4, 2017

That's fantastic @stevenyap, thanks! 👌

@BlueHotDog
Copy link

Typescript support would be awesome.. i'll try..

@Avaq
Copy link
Member

Avaq commented Aug 8, 2017

Typescript support has landed in Fluture 7.0.0 thanks to @tusharmath

@stevenyap
Copy link

stevenyap commented Aug 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants