Fix Static Land compliance of the TypeRep exposed by Flutures module version #109
Conversation
This ensures that Future.of and Future.reject are present in module builds as well as UMD builds.
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 44 45 +1
Lines 1069 1074 +5
=====================================
+ Hits 1069 1074 +5
Continue to review full report at Codecov.
|
|
While reviewing my own code, I realized that for the same reason that |
|
Would you mind having a peek @rpominov? |
Avaq
changed the title
| never, | ||
| isNever | ||
| } from './src/core'; | ||
| export {default, default as Future} from './src/future'; |
There was a problem hiding this comment.
Not 100% sure that ES specification allows to do export {default} from '...'. It maybe the case that it works with current tools by incident, and may not work in the future.
There was a problem hiding this comment.
Reading through the spec, one rule is concerning:
For each IdentifierName
nin ReferencedBindings of ExportClause: It is a Syntax Error if StringValue ofnis a ReservedWord
In the spec for ReservedWord we see that default is actually a reserved word. This would mean that export {Future as default} from '...' also shouldn't work.
There was a problem hiding this comment.
Right. Maybe you should do import Future from './src/future'; export default Future; to be safe.
There was a problem hiding this comment.
It means I have to do it like this:
import _Future from './src/future';
export default _Future;
export const Future = _Future;There was a problem hiding this comment.
Yeah, ugly. But I would probably do it like this though.
There was a problem hiding this comment.
I've made the same mistake in other places of the code. I'll merge this PR as is, and create a separate issue to discuss the matter.
Other than improving the code organization, this ensures that
Future.ofandFuture.rejectare present in module builds as well as UMD builds.As a result, the following will become possible:
I find that many users expect this to work.