Make the Parallel interpreter stack safe #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 48 48
Lines 1097 1102 +5
=====================================
+ Hits 1097 1102 +5
Continue to review full report at Codecov.
|
Avaq
commented
Jul 18, 2017
| @@ -50,7 +50,7 @@ describe('Parallel', () => { | |||
|
|
|||
| it('parallelizes execution', function(){ | |||
| this.timeout(70); | |||
| const actual = parallel(2, [ | |||
| const actual = parallel(5, [ | |||
There was a problem hiding this comment.
This change is mostly unrelated. It corrects an earlier mistake which caused the tests to fail sometimes in Travis.
Avaq
force-pushed
the
avaq/stacksafe-parallel
branch
2 times, most recently
from
2b66668
to
17de9db
Compare
Avaq
force-pushed
the
avaq/stacksafe-parallel
branch
from
17de9db
to
7ccd355
Compare
|
@Avaq WOW! it works perfectly! Amazing job 👍, thx a lot Performance is equals to my reduce/chain hack |
|
Great! I will release it in |
Avaq
added a commit
that referenced
this pull request
Jul 18, 2017
* #128 The performance of transforming Futures has improved significantly. * #131 Future.parallel has been made stack-safe. * #131 Future.parallel now guarantees execution order. * #132 Improve version interoperability. Note that 6.3.x futures will not be compatible with 6.2.x Futures, so when upgrading, make sure to upgrade all producers of Future instances. To avoid having to do this with future releases, I recommend setting Fluture as a devDependency if you are maintaining a library which exposes Future instances to its users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you mind testing this branch against your code, @alexshuhin, to verify whether your issue has been resolved?
Fixes #130