Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sanctuary-type-classes to the latest version 馃殌 #157

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Sep 29, 2017

Version 7.0.0 of sanctuary-type-classes just got published.

Dependency sanctuary-type-classes
Current Version 6.1.0
Type dependency

The version 7.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of sanctuary-type-classes.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 3 commits.

  • f566a33 Version 7.0.0
  • 56a7173 Merge pull request #70 from sanctuary-js/davidchambers/no-inherited
  • 192b4bd ignore inherited properties when enumerating a string map

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 馃尨

@codecov-io
Copy link

codecov-io commented Sep 29, 2017

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #157   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          50     50           
  Lines        1144   1144           
=====================================
  Hits         1144   1144

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update eb0add6...a2d8a4e. Read the comment docs.

@Avaq
Copy link
Member

Avaq commented Oct 9, 2017

The breaking change is ignore inherited properties when enumerating a string map. Fluture uses the following functions: alt, ap, bimap, chain, equals, map, toString. Fluture exposes map to its users. The behaviour of map has changed in a breaking way:

Pre-7.0:

> Z.map(x => x + 1, Object.create({a: 1}))
{ a: 2 }

Post-7.0:

> Z.map(x => x + 1, Object.create({a: 1}))
{}

I believe for this reason, this PR is breaking and should be a major bump in Fluture. Would you agree @davidchambers?

@davidchambers
Copy link
Contributor

I believe for this reason, this PR is breaking and should be a major bump in Fluture. Would you agree @davidchambers?

I agree. I suggest leaving this pull request open until you're ready to release a new major version.

@Avaq Avaq added the breaking label Oct 9, 2017
greenkeeper bot added a commit that referenced this pull request Oct 20, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 20, 2017

Version 7.1.0 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 3 commits.

  • 9db89ad Version 7.1.0
  • 79f608f Merge pull request #71 from sanctuary-js/davidchambers/fantasy-land
  • aef1bf8 fantasy-land@3.4.0

See the full diff

@Avaq
Copy link
Member

Avaq commented Oct 23, 2017

Note to self: merge and release fluture-js/concurrify#11 before merging and releasing this

greenkeeper bot added a commit that referenced this pull request Nov 30, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 30, 2017

Version 7.1.1 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 7 commits.

  • d9255b3 Version 7.1.1
  • a21f399 Merge pull request #75 from sanctuary-js/davidchambers/traverse
  • eab0eea remove improper mutation from Object$prototype$traverse
  • 446983a Merge pull request #73 from sanctuary-js/davidchambers/style
  • 4d909e7 sanctuary-style@1.0.x
  • 9b281d5 Merge pull request #72 from sanctuary-js/davidchambers/circle
  • 8ca78f2 circle: upgrade to CircleCI 2.0

See the full diff

@Avaq Avaq closed this in #194 Dec 30, 2017
Avaq pushed a commit that referenced this pull request Dec 30, 2017
@greenkeeper greenkeeper bot deleted the greenkeeper/sanctuary-type-classes-7.0.0 branch December 30, 2017 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants