-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sanctuary-type-classes to the latest version 馃殌 #157
Conversation
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 50 50
Lines 1144 1144
=====================================
Hits 1144 1144 Continue to review full report at Codecov.
|
The breaking change is ignore inherited properties when enumerating a string map. Fluture uses the following functions: Pre-7.0: > Z.map(x => x + 1, Object.create({a: 1}))
{ a: 2 } Post-7.0: > Z.map(x => x + 1, Object.create({a: 1}))
{} I believe for this reason, this PR is breaking and should be a major bump in Fluture. Would you agree @davidchambers? |
I agree. I suggest leaving this pull request open until you're ready to release a new major version. |
Version 7.1.0 just got published. |
Note to self: merge and release fluture-js/concurrify#11 before merging and releasing this |
Version 7.1.1 just got published.Update to this version instead 馃殌 CommitsThe new version differs by 7 commits.
See the full diff |
Version 7.0.0 of sanctuary-type-classes just got published.
The version 7.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of sanctuary-type-classes.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 3 commits.
f566a33
Version 7.0.0
56a7173
Merge pull request #70 from sanctuary-js/davidchambers/no-inherited
192b4bd
ignore inherited properties when enumerating a string map
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 馃尨