Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow resource disposal Futures from failing #311

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Jan 27, 2019

This is a significant breaking change to how hook handles failure of resource disposal.

Prior to this change, when resource disposal failed:

  • the failure state was propagated if the future had not been cancelled; or
  • the failure was completely ignored if the future had been cancelled.

After this change, when resource disposal fails for whatever reason:

  • a fatal error is raised, which can be handled by forkCatch if the future had not been cancelled; or
  • a fatal error is thrown if the future had been cancelled.

The goal of this change is to be louder about non-disposed resources, and encourage programs to restart in case it happens.

@Avaq Avaq added the breaking label Jan 27, 2019
@Avaq Avaq requested a review from dicearr January 27, 2019 22:21
@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #311 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #311   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          48     48           
  Lines        1074   1074           
  Branches      224    224           
=====================================
  Hits         1074   1074
Impacted Files Coverage Δ
src/hook.mjs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be1335a...af253bc. Read the comment docs.

@Avaq Avaq merged commit b3c630a into master Feb 4, 2019
@Avaq Avaq deleted the avaq/disposal-failure branch February 4, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants