Switch the entire library to a functional-first approach #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
force-pushed
the
avaq/fp-first
branch
3 times, most recently
from
575a452
to
dbec3bc
Compare
This comment has been minimized.
This comment has been minimized.
Avaq
force-pushed
the
avaq/fp-first
branch
10 times, most recently
from
19552e1
to
4c8586a
Compare
Avaq
force-pushed
the
avaq/fp-first
branch
7 times, most recently
from
a95c2e1
to
f37ca0e
Compare
Avaq
force-pushed
the
avaq/fp-first
branch
3 times, most recently
from
b529665
to
d4d2ada
Compare
Avaq
force-pushed
the
avaq/fp-first
branch
5 times, most recently
from
e710503
to
84116b6
Compare
The prior two commits have greatly reduced performance. A few basic tweaks brings performance back to a similar level to what it was.
This comment has been minimized.
This comment has been minimized.
dicearr
reviewed
Apr 24, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Avaq
added a commit
that referenced
this pull request
May 7, 2019
Breaking changes - #326 The internal structure of Fluture has changed - #326 All functions now use simple currying - #326 All function aliases have been removed - #326 `tryP` was renamed to `encaseP` - #326 Properties on the `Future` function have been removed - #326 Various functions have had their arguments flipped - #326 Fantasy Land 0.x is no longer supported - #326 `encaseN` and friends have been removed - #326 `encase2` and up have been removed - #326 `encaseP2` and up have been removed - #326 The entire fluent method API has been removed New features - #326 "Asynchronous stack traces" have been reworked to show more relevant stacks and fewer irrelevant stacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Pass context through _interpret and wire it up for debug modeUndo removal of encase functions?Expose the fluent API in some wayChanges
See the migration guide for a description of breaking changes.
See this gist for a preview of the changes to stack traces. The goal is to limit the captured stack frames to those most relevant to the situation.