Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hook disposing twice when cancelled during disposal #351

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fix hook disposing twice when cancelled during disposal #351

merged 1 commit into from
Jun 20, 2019

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Jun 20, 2019

No description provided.

@Avaq Avaq requested a review from dicearr June 20, 2019 10:39
@Avaq Avaq self-assigned this Jun 20, 2019
@Avaq Avaq changed the base branch from master to 11.x June 20, 2019 10:40
dicearr
dicearr approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@dicearr dicearr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #351 into 11.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           11.x   #351   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        48     48           
  Lines      1074   1074           
  Branches    224    224           
===================================
  Hits       1074   1074
Impacted Files Coverage Δ
src/hook.mjs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8284c87...933630a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 20, 2019 •
edited

Codecov Report

Merging #351 into 11.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           11.x   #351   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        48     48           
  Lines      1074   1074           
  Branches    224    224           
===================================
  Hits       1074   1074
Impacted Files Coverage Δ
src/hook.mjs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8284c87...933630a. Read the comment docs.

@Avaq Avaq merged commit 21f6181 into 11.x Jun 20, 2019
@Avaq Avaq deleted the avaq/hook-bug branch June 20, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicearr dicearr dicearr approved these changes

Assignees

@Avaq Avaq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Avaq @dicearr