Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluvio dependency consistency #4

Open
pinkforest opened this issue Dec 18, 2023 · 0 comments
Open

fluvio dependency consistency #4

pinkforest opened this issue Dec 18, 2023 · 0 comments

Comments

@pinkforest
Copy link
Contributor

pinkforest commented Dec 18, 2023

Re: discussion

Might want to update these too that point to git as well that I followed:

It's not just cdk generate it's in every connector like that thus worth asking :]

Also cdk generate today uses git ref:

$ cdk generate foobar
Generating new Connector project: foobar
🤷   Please set a group name: yak
✔ 🤷   Which type of Connector would you like [source/sink]? · source
✔ 🤷   Will your Connector be public? · true
[1/8]   Done: .gitignore
[2/8]   Done: Cargo.toml
[3/8]   Done: Connector.toml
[4/8]   Done: README.md
[5/8]   Done: sample-config.yaml
[6/8]   Done: src/config.rs
[7/8]   Done: src/main.rs
[8/8]   Done: src

[foobar@localhost infinyon]$ grep fluvio foobar/Cargo.toml
 
fluvio = { git = "https://github.com/infinyon/fluvio", rev = "f9238646dd1b5197977b9c03feba39a78ef89bb8" }
fluvio-connector-common = { git = "https://github.com/infinyon/fluvio", rev = "f9238646dd1b5197977b9c03feba39a78ef89bb8", features = ["derive"]}

ref in fluvio:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant