Add initial nats source connector #2
Conversation
| async fn start(config: NatsConfig, producer: TopicProducer) -> Result<()> { | ||
| debug!(?config); | ||
| let source = NatsSource::new(&config)?; | ||
| let mut stream = source.connect(None).await?; |
There was a problem hiding this comment.
Depending on the long run behavior of Nats/fluvio, it may be interesting to have a larger loop around the connect .. next to implement a longer term re-connect strategy
There was a problem hiding this comment.
Yeah we just crashed the connector and there wasn't really good feedback loop to cluster to handle failing connectors.. it would be good to have some kind of strategy e.g. also observability of these failures
| cloud_e2e_test: | ||
| bats ./tests/cloud-consumes-data-from-nats.bats | ||
|
|
||
| test_fluvio_install: |
There was a problem hiding this comment.
It's in every connector like that - https://github.com/infinyon/http-source-connector/blob/main/Makefile#L19
Should this be removed ?
There was a problem hiding this comment.
Ideally, yes, because it makes no sense to keep it here.
I will remove it from http-source when I have a chance.
Needs to be added:
Can be added later: