Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: developer container environment #398

Merged
merged 1 commit into from Oct 12, 2023

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Oct 12, 2023

Problem: there is no easy way to develop (in a container) and this would be nice if we consider other kinds of bindings. Solution: add a .devcontainer setup.

This is the first step (I think at least) to thinking about Go bindings. I see this is a project in C++ (not C) so I'll look into good ways to do that.

Problem: there is no easy way to develop (in a container)
and this would be nice if we consider other kinds of bindings.
Solution: add a .devcontainer setup.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #398 (dcb09fd) into master (5b14be6) will not change coverage.
The diff coverage is n/a.

❗ Current head dcb09fd differs from pull request most recent head 396e462. Consider uploading reports for the commit 396e462 to get more accurate results

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files          20       20           
  Lines        1419     1419           
=======================================
  Hits         1150     1150           
  Misses        269      269           

Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM! thanks @vsoch! just had one minor question about devcontainer.json

}
},
"postStartCommand": "git config --global --add safe.directory /workspaces/flux-accounting"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it matter if this line does or doesn't have a newline at the end of it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not - it looks like json but actually it breaks many rules of it. I tested this fully and the newline does not seem to make a difference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey you have a new picture! I like it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! my hair is a lot longer now, i don't look much like that graduation photo from 2019 anymore 😆 feel free to set MWP on this whenever you are ready

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks @cmoussa1

@mergify mergify bot merged commit 9fef06e into flux-framework:master Oct 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants