New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: developer container environment #398
Conversation
Problem: there is no easy way to develop (in a container) and this would be nice if we consider other kinds of bindings. Solution: add a .devcontainer setup. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
0ed6cc3
to
396e462
Compare
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 20 20
Lines 1419 1419
=======================================
Hits 1150 1150
Misses 269 269 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM! thanks @vsoch! just had one minor question about devcontainer.json
} | ||
}, | ||
"postStartCommand": "git config --global --add safe.directory /workspaces/flux-accounting" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it matter if this line does or doesn't have a newline at the end of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not - it looks like json but actually it breaks many rules of it. I tested this fully and the newline does not seem to make a difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey you have a new picture! I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! my hair is a lot longer now, i don't look much like that graduation photo from 2019 anymore 😆 feel free to set MWP on this whenever you are ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks @cmoussa1
Problem: there is no easy way to develop (in a container) and this would be nice if we consider other kinds of bindings. Solution: add a .devcontainer setup.
This is the first step (I think at least) to thinking about Go bindings. I see this is a project in C++ (not C) so I'll look into good ways to do that.